Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add database snapshot functionality to Helm chart #9956

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat: add database snapshot functionality to Helm chart #9956

merged 1 commit into from
Sep 23, 2024

Conversation

carolinaecalderon
Copy link
Contributor

@carolinaecalderon carolinaecalderon commented Sep 18, 2024 •
edited
Loading

Ticket

CM-448

Description

See notes: https://hpe-aiatscale.atlassian.net/wiki/spaces/ENGINEERIN/pages/1748041758/Guide+Release+Party+Database+Backups
TLDR; add Helm values such that you can easily snapshot/backup OR restore a database's persistent volume.

Test Plan

Manual testing or N/A

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Sep 18, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 1c4624d
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66f1bb38d4fcb30008ba73e0
😎 Deploy Preview https://deploy-preview-9956--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.49%. Comparing base (f758303) to head (1c4624d).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9956      +/-   ##
==========================================
- Coverage   54.50%   54.49%   -0.01%     
==========================================
  Files        1255     1255              
  Lines      156733   156733              
  Branches     3601     3600       -1     
==========================================
- Hits        85424    85414      -10     
- Misses      71176    71186      +10     
  Partials      133      133
Flag Coverage Δ
backend 45.14% <ø> (-0.02%) ⬇️
harness 72.74% <ø> (ø)
web 54.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@carolinaecalderon carolinaecalderon changed the title Carolinac/rp db snapshot feat: add database snapshot functionality to Helm chart Sep 19, 2024
@carolinaecalderon carolinaecalderon marked this pull request as ready for review September 19, 2024 21:34
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Sep 20, 2024
@determined-ci determined-ci requested a review from a team September 20, 2024 16:37
maxrussell
maxrussell approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@maxrussell maxrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High-level, I like the values and docs! Left a couple comments of minor questions/suggestions. Approving, though, because they're optional if you don't think they'd be improvements.

docs/reference/deploy/helm-config-reference.rst Outdated Show resolved Hide resolved
docs/reference/deploy/helm-config-reference.rst Outdated Show resolved Hide resolved
@determined-ci determined-ci requested a review from a team September 23, 2024 16:38
tara-det-ai
tara-det-ai approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added suggested edits

@determined-ci determined-ci requested a review from a team September 23, 2024 19:02
@carolinaecalderon carolinaecalderon merged commit 5c4be96 into main Sep 23, 2024
87 of 99 checks passed
@carolinaecalderon carolinaecalderon deleted the carolinac/rp-db-snapshot branch September 23, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tara-det-ai tara-det-ai tara-det-ai approved these changes

@maxrussell maxrussell maxrussell approved these changes

@mackrorysd mackrorysd Awaiting requested review from mackrorysd

@davidfluck-hpe davidfluck-hpe Awaiting requested review from davidfluck-hpe

Assignees
No one assigned
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carolinaecalderon @maxrussell @tara-det-ai @determined-ci